Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java-cdk: better debezium logging #41212

Merged
merged 4 commits into from
Jul 11, 2024
Merged

java-cdk: better debezium logging #41212

merged 4 commits into from
Jul 11, 2024
+95 −26

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Jul 9, 2024 •
edited
Loading

What

Database sources using Debezium now print more informative log messages.

How

Using a time and count based strategy we print log messages in a reasonably- but not overly chatty way.

Review guide

User Impact

None, this is to make debugging customer issues easier.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Jul 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2024 5:11pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/source/mssql labels Jul 9, 2024
@postamar postamar marked this pull request as ready for review July 9, 2024 21:16
@postamar postamar requested a review from a team as a code owner July 9, 2024 21:16
@postamar postamar force-pushed the postamar/better-dbz-logging branch 2 times, most recently from 8f1f6ab to dd8c9b8 Compare July 10, 2024 01:12
@xiaohansong
Copy link
Contributor

Remember to bump up the connector too

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 10, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • coderabbit-ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

postamar and others added 3 commits July 11, 2024 13:07
@postamar
java-cdk: better debezium logging
8590002
@akashkulk @postamar
Updates in heartbeat shutdown logic
5180f87 
- Logging to understand when airbyte receives the first record from DBZ
- Changes to DBZ shutdown logic : Shut DBZ if heartbeat isn't changing for a while BEFORE Airbyte has already received a message. If Airbyte has received a message from DBZ, then we can lean on platform to perform the shutdown
@postamar
chore: format code
ada6421
@postamar postamar force-pushed the postamar/better-dbz-logging branch from c304a0e to ada6421 Compare July 11, 2024 17:07
@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label Jul 11, 2024
@postamar postamar requested a review from a team as a code owner July 11, 2024 17:11
@postamar
Copy link
Contributor Author

postamar commented Jul 11, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/9896292682
✅ Successfully published Java CDK version=0.41.1!

@postamar postamar merged commit 10a2614 into master Jul 11, 2024
28 checks passed
@postamar postamar deleted the postamar/better-dbz-logging branch July 11, 2024 19:20
@postamar postamar mentioned this pull request Jul 11, 2024
Closed
2 tasks
xiaohansong pushed a commit that referenced this pull request Jul 12, 2024
@postamar @akashkulk @xiaohansong
java-cdk: better debezium logging (#41212)
f46416d 
Co-authored-by: Akash Kulkarni <akash@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaohansong xiaohansong xiaohansong approved these changes

Assignees
No one assigned
Labels
CDK Connector Development Kit connectors/source/mssql connectors/source/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@postamar @xiaohansong @octavia-squidington-iii @akashkulk