Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker credentials warning #113

Closed
lgvaz opened this issue Jun 23, 2020 · 3 comments
Closed

Docker credentials warning #113

lgvaz opened this issue Jun 23, 2020 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@lgvaz
Copy link
Collaborator

lgvaz commented Jun 23, 2020

🐛 Bug

Currently the docker action is giving the following warning:

WARNING! Your password will be stored unencrypted in /github/home/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

It's not so clear if that is a flaw or not, but from this issue it seems that the best solution would be to use the official docker action

@oke-aditya can you check this one?

@lgvaz lgvaz added the bug Something isn't working label Jun 23, 2020
@lgvaz lgvaz added this to the incubator milestone Jun 23, 2020
@lgvaz
Copy link
Collaborator Author

lgvaz commented Jun 23, 2020

Btw, for checking a custom branch in the action, you should use:

- uses: actions/checkout@v2
  with:
    ref: my-branch

Take a look here for more info

@oke-aditya
Copy link
Contributor

This is issue is open with Docker official action as well. They are looking into it.
Have a look here.

docker/build-push-action#53

I hope they will fix it soon.

@oke-aditya
Copy link
Contributor

As of now the best thing is to use the official docker action. And Keep this issue opened. One docker officially resolves it and we verify. We can close it.

@lgvaz lgvaz assigned oke-aditya and lgvaz and unassigned oke-aditya Jun 23, 2020
@lgvaz lgvaz removed their assignment Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants