Invalid ReplacementTransformer behavior if dot is in pattern string

[jingvar]

Describe the bug
If ReplacementTransformer has a pattern with a dot , it generates a message
"pattern-based substitution can only be applied to string target fields"

Steps To Reproduce
config.yaml

apiVersion: airshipit.org/v1alpha1
kind: ReplacementTransformer
metadata:
  name: notImportantHere
replacements:
- source:
    value: 12345678
  target:
    objref:
      kind: KubeadmControlPlane
    fieldrefs:
    - spec.kubeadmConfigSpec.files[path=konfigadm.yaml].content%{k8s-version}%

test.yaml

apiVersion: controlplane.cluster.x-k8s.io/v1alpha3
kind: KubeadmControlPlane
metadata:
  name: cluster-controlplane
spec:
  infrastructureTemplate:
    apiVersion: infrastructure.cluster.x-k8s.io/v1alpha3
    kind: Metal3MachineTemplate
    name: $(cluster-name)
  kubeadmConfigSpec:
    files:
    - content: |
        kubernetes:
          version: {k8s-version}
        container_runtime:
          type: docker
      owner: root:root
      path: konfigadm.yaml
      permissions: "0640"

Expected behavior
Should work like a dotless pattern.

Environment
airshipctl build from commit f555af3

[airshipbot]

Related Change #723516

Subject: Replacement transformer improvement
Link: https://review.opendev.org/723516
Status: MERGED
Owner: Dmitry Ukov (dukov@mirantis.com)

This change will close this issue when merged.

Approvals

Code-Review
+1 John Williams
+2 Alexander Hughes
+2 Pete Birley
Verified
+2 Zuul
Workflow
+1 Matt McEuen

Last Updated: 2020-04-29 18:00:05 CDT