Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that Configuration Exists during Config Load #194

Closed
eak13 opened this issue Apr 29, 2020 · 2 comments
Closed

Validate that Configuration Exists during Config Load #194

eak13 opened this issue Apr 29, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@eak13
Copy link

eak13 commented Apr 29, 2020

Problem description
Invalid variable configuration can cause null pointer issues leading to runtime errors (e.g. uninitialized maps). When configuration is loaded specific sub-command validations are not performed until the sub-command operation. There is a need to validate that configuration exists at the time it is loaded.
Reference issue #190 - Invalid config could cause runtime error

Proposed change
Enhance the airship config load to throw a warning if there is no configuration.

Potential impacts
By expanding the pool of upfront validations, we can eliminate runtime errors due to bad configurations at the sub-command level.

@eak13 eak13 added enhancement New feature or request triage Needs evaluation by project members labels Apr 29, 2020
@eak13 eak13 changed the title Provide sub-command level validation of config options Validate that Configuration Exists during Config Load May 5, 2020
@jezogwza jezogwza added good first issue Good for newcomers and removed triage Needs evaluation by project members labels May 6, 2020
@jezogwza jezogwza added this to the betav1 milestone May 6, 2020
@ian-howell ian-howell self-assigned this May 18, 2020
@ian-howell
Copy link
Contributor

I believe this may be implemented already, but I'll take a look prior to closing

@ian-howell
Copy link
Contributor

Closing as this is a duplicate of #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants