Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EnsureComplete validation when setting config object in airshipctl cluster #214

Closed
eak13 opened this issue May 5, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers priority/low Items that are considered non-critical for functionality, such as quality of life improvements
Milestone

Comments

@eak13
Copy link

eak13 commented May 5, 2020

Proposed change
When setting the config object, airshipctl cluster should use settings.Config.EnsureComplete() to validate that a config object is ready to use.

EnsureComplete does the following checks & returns an error if any one is not met.

  • At least 1 Cluster is defined
  • At least 1 AuthInfo (user) is defined
  • At least 1 Context is defined
  • At least 1 Manifest is defined
  • The CurrentContext is set
  • The CurrentContext identifies an existing Context
  • The CurrentContext identifies an existing Manifest

Potential impacts
This will improve config object validations & identify potential issues upfront before continuing to execute the workflow.

@eak13 eak13 added enhancement New feature or request triage Needs evaluation by project members labels May 5, 2020
@jezogwza jezogwza added good first issue Good for newcomers priority/low Items that are considered non-critical for functionality, such as quality of life improvements and removed triage Needs evaluation by project members labels May 6, 2020
@jezogwza jezogwza added this to the v2.0 milestone May 6, 2020
@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label May 15, 2020
@airshipbot
Copy link

airshipbot commented May 15, 2020

Related Change #728557

Subject: Add EnsureComplete check to cluster init
Link: https://review.opendev.org/728557
Status: MERGED
Owner: Ian Howell (ian.howell0@gmail.com)

This change will close this issue when merged.

Approvals

Code-Review
+1 Ruslan Aliev
+1 Vladislav Kuzmin
+1 Stas Egorov
+2 Alexander Hughes
+2 Matt McEuen
Verified
+2 Zuul
Workflow
+1 Matt McEuen

Last Updated: 2020-05-19 23:45:03 CDT

@eak13 eak13 removed the ready for review Change related to the issue is ready for review label Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers priority/low Items that are considered non-critical for functionality, such as quality of life improvements
Projects
None yet
Development

No branches or pull requests

3 participants