Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go lint as a non-voting gate. #253

Closed
ian-howell opened this issue May 27, 2020 · 1 comment
Closed

Add go lint as a non-voting gate. #253

ian-howell opened this issue May 27, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request triage Needs evaluation by project members

Comments

@ian-howell
Copy link
Contributor

Problem description
Issue #58 proposed adding go lint to the linting toolchain. As @sirajyasin noted in https://review.opendev.org/#/c/729645, the implementation of go lint included in golangci-lint has some slight variations on linting requirements. This causes various warnings from go lint to be suppressed (mostly missing documentation). While not required, it would be useful to be notified when those warnings exist.

Proposed change
Add a non-voting gate for go lint

@ian-howell ian-howell added enhancement New feature or request triage Needs evaluation by project members labels May 27, 2020
@ian-howell ian-howell self-assigned this May 28, 2020
@airshipbot
Copy link

airshipbot commented May 28, 2020

Related Change #731608

Subject: Add golint as a non-voting gate
Link: https://review.opendev.org/731608
Status: MERGED
Owner: Ian Howell (ian.howell0@gmail.com)

This change will close this issue when merged.

Approvals

Code-Review
+2 Drew Walters
+2 Dmitry Ukov
Verified
+2 Zuul
Workflow
+1 Dmitry Ukov

Last Updated: 2020-06-01 12:00:03 CDT

@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label May 28, 2020
@eak13 eak13 removed the ready for review Change related to the issue is ready for review label Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Needs evaluation by project members
Projects
None yet
Development

No branches or pull requests

3 participants