Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md for policy against too large Gerrit Patches #289

Closed
demonCoder95 opened this issue Jul 3, 2020 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@demonCoder95
Copy link

Problem description (if applicable)
Currently, there's quite a bit of changes in Gerrit that are just TOO LARGE; 1000s of lines in dozens of files. All of these are providing too many components/features within a single change. This makes the review process extremely challenging, and also goes against the opendev development guidelines.

Proposed change
I suggest a note in the CONTRIBUTING.md file for awareness against this. Smaller well-defined changes in Gerrit will improve as well as facilitate code review!

Potential impacts
N/A

@demonCoder95 demonCoder95 added enhancement New feature or request triage Needs evaluation by project members labels Jul 3, 2020
@demonCoder95
Copy link
Author

demonCoder95 commented Jul 3, 2020

Assign this to me

@airshipbot
Copy link

airshipbot commented Jul 3, 2020

Related Change #739263

Subject: Guideline against very large Gerrit Changes
Link: https://review.opendev.org/739263
Status: MERGED
Owner: Noor Muhammad Malik (noormuhammadmalik95@gmail.com)

This change will close this issue when merged.

Approvals

Code-Review
+2 Ian Howell
+2 Alexander Hughes
Verified
+2 Zuul
Workflow
+1 Alexander Hughes

Last Updated: 2020-07-06 19:00:04 CDT

@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label Jul 3, 2020
@airshipbot
Copy link

The Change that closes this issue was merged.

@airshipbot airshipbot added ready for review Change related to the issue is ready for review and removed ready for review Change related to the issue is ready for review triage Needs evaluation by project members labels Jul 6, 2020
@eak13 eak13 removed the ready for review Change related to the issue is ready for review label Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants