Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom kubeconfig contexts for clusters #380

Closed
teoyaomiqui opened this issue Oct 28, 2020 · 2 comments
Closed

Add support for custom kubeconfig contexts for clusters #380

teoyaomiqui opened this issue Oct 28, 2020 · 2 comments
Labels
enhancement New feature or request ready for review Change related to the issue is ready for review

Comments

@teoyaomiqui
Copy link
Contributor

Currently we have a contract between kubeconfig and clusters managed by airshipctl, that cluster name MUST correspond to cluster name.

For easier management I propose that we allow users to specify kubeconfig context per cluster in ClusterMap object, and adding corresponding method to ClusterMap interface in pkg/cluster/clustermap

This would allow for easier merging of kubeconfig into document set, and easier to bring external kubeconfigs to airshipctl.
Default behavior would be still to use cluster name, if context is not specified

@teoyaomiqui teoyaomiqui added enhancement New feature or request triage Needs evaluation by project members labels Oct 28, 2020
@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label Oct 28, 2020
@airshipbot
Copy link

airshipbot commented Oct 28, 2020

Related Change #759763

Subject: Add support for custom kubeconfig contexts
Link: https://review.opendev.org/759763
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

This change will close this issue when merged.

Approvals

Code-Review
+2 Matt McEuen
+1 srinivasa muly
+2 Dmitry Ukov
+1 Bijaya Sharma
Verified
+2 Zuul
Workflow
+1 Kostyantyn Kalynovskyi

Last Updated: 2020-11-02 20:15:03 CST

@airshipbot
Copy link

The Change that closes this issue was merged.

@airshipbot airshipbot removed ready for review Change related to the issue is ready for review triage Needs evaluation by project members labels Nov 3, 2020
@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready for review Change related to the issue is ready for review
Projects
None yet
Development

No branches or pull requests

2 participants