Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve static validation solution #563

Closed
raliev12 opened this issue Jun 4, 2021 · 1 comment
Closed

Improve static validation solution #563

raliev12 opened this issue Jun 4, 2021 · 1 comment
Assignees
@raliev12
Labels
1-Core Relates to airshipctl core components (i.e. go code) enhancement New feature or request priority/medium Default priority for items
Milestone
v2.1

Comments

@raliev12
Copy link
Contributor

raliev12 commented Jun 4, 2021

Problem description (if applicable)
There are several changes/improvements required to bring static validation to the last related design call state.

Proposed change

  • move validation configuration from site documents and make it part of airshipctl api (phase/plan structs);
  • import additional CRDs only as kustomize entrypoints and provide them along with documents for validation;
  • do not mount whole set of airshipctl manifests to the KRM container

Potential impacts
None.
@raliev12 raliev12 added enhancement New feature or request triage Needs evaluation by project members labels Jun 4, 2021
@jezogwza jezogwza added the priority/medium Default priority for items label Jun 9, 2021
@jezogwza jezogwza added 1-Core Relates to airshipctl core components (i.e. go code) and removed triage Needs evaluation by project members labels Jun 9, 2021
@jezogwza jezogwza modified the milestones: v2.2, v2.1 Jun 9, 2021
@raliev12
Copy link
Contributor Author

raliev12 commented Jun 9, 2021

Related PS - https://review.opendev.org/c/airship/airshipctl/+/789398

@eak13 eak13 modified the milestones: v2.1, Future Jun 11, 2021
@lb4368 lb4368 modified the milestones: Future, v2.1 Jun 15, 2021
@eak13 eak13 mentioned this issue Jun 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raliev12 raliev12

Labels
1-Core Relates to airshipctl core components (i.e. go code) enhancement New feature or request priority/medium Default priority for items
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
4 participants
@lb4368 @eak13 @jezogwza @raliev12