Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike: Validate Node Label changes can be made through Metal3 BMH #615

Closed
lb4368 opened this issue Jul 13, 2021 · 4 comments
Closed

Spike: Validate Node Label changes can be made through Metal3 BMH #615

lb4368 opened this issue Jul 13, 2021 · 4 comments
Assignees
@sshiba
Labels
Day2 Relates to day 2 operations (brownfield upgrades, etc.) enhancement New feature or request size m
Milestone
v2.1

Comments

@lb4368
Copy link

lb4368 commented Jul 13, 2021

Proposed change
The PR (metal3-io/cluster-api-provider-metal3#152) in CAPM3 allows for configuration of labels to be synced between BMH resources and K8s nodes and is included in CAPM3 version 0.4.2. Would like to confirm this capability in Airship to make node label changes via BMH.
@lb4368 lb4368 added enhancement New feature or request triage Needs evaluation by project members Day2 Relates to day 2 operations (brownfield upgrades, etc.) labels Jul 13, 2021
@lb4368 lb4368 added this to the v2.2 milestone Jul 13, 2021
@jezogwza jezogwza removed the triage Needs evaluation by project members label Jul 14, 2021
@drewwalters96
Copy link
Contributor

drewwalters96 commented Jul 14, 2021 •
edited
Loading

Since I am implementing airshipit/treasuremap#186 with this feature, I can also verify that the new controller syncs the labels when the BMHs are updated

@drewwalters96 drewwalters96 self-assigned this Jul 14, 2021
@eak13 eak13 added the size m label Jul 26, 2021
@mattmceuen mattmceuen mentioned this issue Aug 25, 2021
Open
@sshiba
Copy link

sshiba commented Oct 6, 2021

This issue has been validated on Ephemeral cluster and Target cluster deployed using airshipctl on CAPI v1alpha4/CAPM3 v0.5.0 uplift (patchsets).

The validation process has been documented in Spike CPVYGR-484: Validate Node Label Synch between Resources BMH and Node - HackMD

@sshiba
Copy link

sshiba commented Oct 6, 2021

Review of hackmd.io document added to the Design Review of Oct 19th.

@lb4368 lb4368 assigned sshiba and unassigned drewwalters96 Oct 22, 2021
@lb4368
Copy link
Author

lb4368 commented Oct 22, 2021

Review complete. Closing.

@lb4368 lb4368 closed this as completed Oct 22, 2021
@eak13 eak13 modified the milestones: v2.2, v2.1 Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sshiba sshiba

Labels
Day2 Relates to day 2 operations (brownfield upgrades, etc.) enhancement New feature or request size m
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
5 participants
@lb4368 @sshiba @eak13 @jezogwza @drewwalters96