Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIAP: Switch to a readiness probe for the docker and libvirt containers #629

Closed
ian-howell opened this issue Sep 3, 2021 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request priority/low Items that are considered non-critical for functionality, such as quality of life improvements
Milestone

Comments

@ian-howell
Copy link
Contributor

Problem description (if applicable)
The artifact-setup and infra-builder containers are using a naive approach of simply sleeping for 30 seconds, with the expectation that the libvirt and docker services will become available in that time before they begin execution:

Proposed change
Modify the base AIAP PodSpec to use readiness probes so the above containers can be sure the services are available. This will prevent errors in the case where the services take a long time to come up while also providing a potential speed boost when they come up very quickly.

@ian-howell ian-howell added enhancement New feature or request triage Needs evaluation by project members labels Sep 3, 2021
@ian-howell
Copy link
Contributor Author

After thinking about this for a minute, a readiness probe may not be the exact mechanism for this task. However, it would still be nice to have a more intelligent waiting mechanism than sleep

@lb4368 lb4368 added priority/low Items that are considered non-critical for functionality, such as quality of life improvements and removed triage Needs evaluation by project members labels Sep 8, 2021
@lb4368 lb4368 added this to the v2.2 milestone Sep 8, 2021
@sirajyasin
Copy link
Contributor

I can start working on this issue.

@sreejithpunnapuzha
Copy link
Member

@sirajyasin all yours

@eak13 eak13 modified the milestones: v2.2, v2.1 Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/low Items that are considered non-critical for functionality, such as quality of life improvements
Projects
None yet
Development

No branches or pull requests

5 participants