running profile without commit results in obscure AttributeError: 'Results' object has no attribute 'env'

[yarikoptic]

$> asv profile  api.testds.time_create_test_dataset2x2      
Traceback (most recent call last):
  File "/home/yoh/proj/datalad/datalad/venvs/dev/bin/asv", line 11, in <module>
    load_entry_point('asv', 'console_scripts', 'asv')()
  File "/home/yoh/proj/misc/asv/asv/main.py", line 38, in main
    result = args.func(args)
  File "/home/yoh/proj/misc/asv/asv/commands/__init__.py", line 49, in run_from_args
    return cls.run_from_conf_args(conf, args)
  File "/home/yoh/proj/misc/asv/asv/commands/profiling.py", line 94, in run_from_conf_args
    **kwargs)
  File "/home/yoh/proj/misc/asv/asv/commands/profiling.py", line 148, in run
    for env in environments)
  File "/home/yoh/proj/misc/asv/asv/commands/profiling.py", line 148, in <genexpr>
    for env in environments)
AttributeError: 'Results' object has no attribute 'env'

and runs ok if I give HEAD

$> asv profile api.testds.time_create_test_dataset2x2 HEAD
· Discovering benchmarks
·· Uninstalling from virtualenv-py2.7.
·· Building ed8136f8 <bm-monkey-patch-is-interactive> for virtualenv-py2.7.
·· Installing ed8136f8 <bm-monkey-patch-is-interactive> into virtualenv-py2.7.
· Profile data does not already exist. Running profiler now.
·· Benchmarking virtualenv-py2.7
··· Running (api.testds.time_create_test_dataset2x2--).
··· api.testds.time_create_test_dataset2x2         
...

$> asv --version
asv 0.4.dev1608+7afea8e5

[jbrockmendel]

I'm getting the same error, but specifying HEAD doesn't help

[HaoZeke]

Can't reproduce this on master.

asv profile benchmarks.*.time_keys
· Discovering benchmarks
· Profile data does not already exist. Running profiler now.
·· Benchmarking virtualenv-py3.11
··· Running (benchmarks.TimeSuite.time_keys--).
··· benchmarks.TimeSuite.time_keys          3.83±0.04μs

Sun Mar 19 21:09:05 2023    /tmp/tmpo7g2mfj_

         5 function calls in 0.000 seconds

   Ordered by: cumulative time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
        1    0.000    0.000    0.000    0.000 {built-in method builtins.exec}
        1    0.000    0.000    0.000    0.000 /home/rgoswami/Git/Github/Python/asv/asv/benchmark.py:473(method_caller)
        1    0.000    0.000    0.000    0.000 /home/rgoswami/Git/Github/Python/blah/benchmarks/benchmarks.py:29(time_keys)
        1    0.000    0.000    0.000    0.000 {method 'keys' of 'dict' objects}
        1    0.000    0.000    0.000    0.000 {method 'disable' of '_lsprof.Profiler' objects}

[brandonwillard]

I'm seeing this issue with asv at 0.6.3 and asv_runner 0.2.1 (not sure if the latter is relevant here).

Looking at the asv.results.Results class I don't see where Results gets a .env field, nor do I see it referenced or used anywhere in asv aside from the asv.profiling.Profile.run (i.e. where the error occurs).

Changing result.env.name to result.env_name works until result.env.checkout_project is needed.