Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PY2 support? #909

Closed
jbrockmendel opened this issue Feb 24, 2020 · 3 comments · Fixed by #1136
Closed

Drop PY2 support? #909

jbrockmendel opened this issue Feb 24, 2020 · 3 comments · Fixed by #1136
Labels
idea Low-priority enhancement suggestion

Comments

@jbrockmendel
Copy link
Contributor

A fair amount of compat code could be removed if PY2 support were dropped. If I understand correctly, it could even be dropped for everything but benchmark.py and retain most of the relevant functionality; is that correct?

@pv pv added the idea Low-priority enhancement suggestion label May 16, 2020
@dorothykiz1
Copy link
Contributor

What are your thoughts on dropping Py2 support and all its dependencies in asv so that we unlock the use of Python 3 syntax modules in the asv codebase?

@datapythonista
Copy link
Member

Personally I'd do it immediately after the release (#967). I guess we can request Python 3.7 or 3.8.

Then we can update setup.py (https://github.com/airspeed-velocity/asv/blob/master/setup.py#L264), set up the CI to test with the minimum and the latest Python version, and then code can be slowly improved after that.

Any comment or objection to the above?

@HaoZeke
Copy link
Member

HaoZeke commented Feb 11, 2024

I don't think there's any other Python 2x code left, if so they can be removed by PRs without this issue..

@HaoZeke HaoZeke closed this as completed Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Low-priority enhancement suggestion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants