Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: logging configuration from file #1772

Open
1984742628 opened this issue Sep 8, 2024 · 0 comments
Open

Feature: logging configuration from file #1772

1984742628 opened this issue Sep 8, 2024 · 0 comments
Labels
Core Issues related to core FastStream functionality and affects to all brokers enhancement New feature or request good first issue Good for newcomers

Comments

@1984742628
Copy link

Is your feature request related to a problem? Please describe.
I would like to use --log-config argument in FastStream CLI to automatically load my logging configuration from file. This functionality is present in uvicorn and gunicorn.

Describe the solution you'd like
FastStream CLI could load configuration file based on extension and use either logging.fileConfig or logging.dictConfig (with proper parsing).

Feature code example
This is the example in gunicorn source code:
https://github.com/benoitc/gunicorn/blob/903792f152af6a27033d458020923cb2bcb11459/gunicorn/glogging.py#L243

Describe alternatives you've considered
I'm currently using my own class that does the same thing but I thought it would be handy to have it implemented in FastStream.

Additional context
This functionality in gunicorn uses logging.dictConfig and logging.fileConfig.
Most likely because logging.fileConfig does not support JSON files.

@1984742628 1984742628 added the enhancement New feature or request label Sep 8, 2024
@Lancetnik Lancetnik added the Core Issues related to core FastStream functionality and affects to all brokers label Sep 8, 2024
@Lancetnik Lancetnik moved this to Backlog in FastStream Sep 8, 2024
@Lancetnik Lancetnik added the good first issue Good for newcomers label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issues related to core FastStream functionality and affects to all brokers enhancement New feature or request good first issue Good for newcomers
Projects
Status: Backlog
Development

No branches or pull requests

2 participants