-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding a default rule for <SUBDOMAINS> #30
Comments
I'm not sure that's a good idea. Tracking tools hiding behind subdomains is a well-known problem, that's why uBlock Origin has CNAME uncloaking. I think implementing #15 and then adding rules for specific 2nd level domains where you really need this would be a better solution. |
I knew about that uBlock Origin option but didn't think of it while using your extension, so now I understand your reasoning for not wanting users to However, I've found out that all sites that I've encountered so far that were broken because of this could actually be fixed by just spoofing all referers to their respective pruned base domains. For instance:
What about adding an option for this to be the default behavior for subdomains? This would make the extension avoid breaking many sites without potentially compromising the privacy of users who enabled it. If you make requests to |
#68 will let you define rules that apply within domains including their subdomains by setting target and origin to the same (e.g.) second level domain. Tests and comments welcome! 😺 |
I think that my last comment was too confusing. You didn't like the idea of adding the option to So, I pointed out that having In other words, my request is to add this option: That way, users won't need to manually add domain-specific rules like these to unbreak sites: |
My main point is that with origin matching you can actually restrict whatever action to requests within a second level domain, instead of all requests to the domain. Of course that's way less of a concern if "replace" is sufficient, I have three domains where "keep" within the second level domain is necessary to make certain things work. And with a default "prune" (I would not want to add a special action) for "same second level domain" I'd still have to have those rules. Is it much more different for you? From my own usage I would consider additional options not worth the effort, but either way I'll unlink the PR. |
I got it, but all of my specific rules have either
I'm comfortable with the extension too, but it can be too troublesome for new users. With my proposal, people wouldn't need to troubleshoot as many broken sites, especially if they set If I had created this extension, I'd go as far as creating a default whitelist, which could be based on the referrer entries in the AdGuard Stealth Mode whitelist. It could, at least, unbreak things like Google Drive videos by default (target: This is your project, though, so it's okay if your final decision is to keep everything the way it is. |
I was about to create a new issue since I just assumed that the same domain rule was also including subdomains like other rules and was wondering why my request to Now I spent 20 minutes of my life on this and have a rather silly looking Just letting you know that this is still an issue people face. Maybe explicitly state that the same domain default rule does not match subdomains or consider a default list to unbreak common sites like suggested above. |
Referer Modifier has a
<SAME>
rule that allows users to keep first-party referers, but it strictly adheres to full local hostnames, removing referers from requests betweenexample.org
anddownload1.example.org
.Other extensions, such as Smart Referer and Privacy Possum, consider subdomains as belonging to the same website by default, and even strongly recommend users to keep the settings that away to avoid breaking sites unexpectedly.
Since you've chosen to code
<SAME>
in its current form, please consider adding a new default rule for<SUBDOMAINS>
, which maybe can stay grayed-out unless<SAME>
is set toKeep
.The text was updated successfully, but these errors were encountered: