Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request host permissions if necessary #82

Open
airtower-luna opened this issue Nov 6, 2022 · 1 comment
Open

Request host permissions if necessary #82

airtower-luna opened this issue Nov 6, 2022 · 1 comment
Milestone

Comments

@airtower-luna
Copy link
Owner

With Manifest v3 host permissions (used to modify requests and inject scripts) have to be requested via host_permissions (see migration guide). Host permission are optional as a matter of principle, and as I found in tests not granted on install by default (or at least not the way Selenium does the installation).

Extensions can check if they have certain permissions and request them using the permissions API.

If it stays that way for the Manifest v3 release, the following seems like a reasonable approach:

  • Install the extension with modifications disabled.
  • If the user enables the extension, request host permissions.
@airtower-luna airtower-luna added this to the Manifest v3 milestone Nov 6, 2022
@airtower-luna
Copy link
Owner Author

declarativeNetRequest works without host permission, but is very limited: For modifying headers, the header can only be removed, or set/appended to with a fixed string. This would break "prune" and "target" rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant