Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design for options page #9

Open
airtower-luna opened this issue Dec 27, 2019 · 2 comments
Open

Design for options page #9

airtower-luna opened this issue Dec 27, 2019 · 2 comments
Labels
enhancement New feature or request help wanted Please contribute code if you'd like this

Comments

@airtower-luna
Copy link
Owner

airtower-luna commented Dec 27, 2019

The options page right now is very much a "works for me" style. It'd be nice to have proper CSS styles, and maybe an updated structure too. Input validation before saving would be a plus.

AMO documentation recommends using the Photon Design System.

Some potential features like source match (#15) or regular expressions (#6) will need room for configuration, so opening a separate setting page instead of including options in the add-on view might be better to have more room.

I'd rather not add any dependencies.

@airtower-luna airtower-luna added enhancement New feature or request help wanted Please contribute code if you'd like this labels Dec 27, 2019
@airtower-luna
Copy link
Owner Author

Another consideration: The table style doesn't scale well on small displays (like mobile devices). I wonder if there's a better way to do it, maybe with elements that arrange in a table-like grid if there's room, but collapse into individual boxes with their own labels if there isn't?

@Gitoffthelawn
Copy link
Contributor

Maybe a flex grid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Please contribute code if you'd like this
Projects
None yet
Development

No branches or pull requests

2 participants