Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with the latest axios (v.1) #57

Closed
kingmaker-agm opened this issue Nov 6, 2022 · 2 comments
Closed

Issue with the latest axios (v.1) #57

kingmaker-agm opened this issue Nov 6, 2022 · 2 comments
Assignees

Comments

@kingmaker-agm
Copy link

This library has used the axios: ^0.18.0 as a devDependency to pull in the Axios while development.

  • It has to be in the dependency section of the package.json to force relevant Axios version constraint as well.
{
   "dependencies": {
      "axios": "^0.18.0",
   }
}

This way your package will not be installed in the projects using axios: 1.13.0.

I used your library to solve the rate limiting Issue in our project, But wasted an entire day as I relied on TS to tell me there wasn't any Error. Found out the Issue doing debugging the runtime values.

@aishek aishek self-assigned this May 29, 2024
@aishek
Copy link
Owner

aishek commented May 29, 2024

Thank you for notice that! I've updated the spec to:

  "dependencies": {
    "axios": ">=0.18.0"
  },

Also I've added tests against both main versions of axois

#72

@aishek
Copy link
Owner

aishek commented May 29, 2024

@aishek aishek closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants