Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game type (pre-season vs regular season) #12

Open
benpackard opened this issue May 19, 2018 · 3 comments
Open

Game type (pre-season vs regular season) #12

benpackard opened this issue May 19, 2018 · 3 comments
Assignees

Comments

@benpackard
Copy link

I'm not sure if this is easily available in the source data but it would be helpful to know whether each score is for a preseason/regular season/postseason game.

@dgmdan
Copy link
Collaborator

dgmdan commented May 24, 2018

I've been wanting this too and started working on it on a branch: https://github.com/aj0strow/espn-scraper/compare/season-type-and-game-status The branch also gets the game status (scheduled, in progress, completed). I have some work remaining on it. I was having a hard time getting that data for NHL scores since we scrape in a bit of a sloppier way there (in winner_loser_parse). I was also struggling to come up with a way to add tests for things like in progress scores, since we can't always expect a live game to be going on in every sport when running tests. I plan on working on it again in the next few weeks but if you're interested, feel free to pick up where I left off and open a PR.

@dgmdan dgmdan self-assigned this Jun 11, 2018
@bakerjalexander
Copy link

If you can determine whether or not a game is in progress, is it possible to return a period and time-left for those games as well?

@dgmdan
Copy link
Collaborator

dgmdan commented Aug 19, 2018

@bakerjalexander I'll aim to include that, although I don't need it personally. I don't think it will be too much extra work. Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants