Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement for editText and editFile #552

Open
cmdjulian opened this issue Sep 16, 2024 · 4 comments
Open

Replacement for editText and editFile #552

cmdjulian opened this issue Sep 16, 2024 · 4 comments

Comments

@cmdjulian
Copy link

cmdjulian commented Sep 16, 2024

Hey,
since version 5.0.0 the two methods editText and editFile have been removed as part of the removal of TermUi. As my app depends on it, I was wondering if there is an replacement for those two functions. There were also not marked as @Deprecated as one would expect.
The documentation seems to still refer to the old TermUi object. There seems to be no proxy methods added within CliktCommand like the following comment suggests #344 (comment)

Thanks in advance.

@ajalt
Copy link
Owner

ajalt commented Sep 17, 2024

Thanks for the heads up on the docs, they should be fixed now.

The TermUi editor functions were the only usages of expect/actual, so removing them means all that's left is commonMain, so it's easier to publish on every target. I could add similar functionality to mordant, which already has a lot of platform-specific implementations.

@cmdjulian
Copy link
Author

That would be really good, as it effectively let's the user a little bit in the rain here without proper replacement like in my case :(
This is a rather handy utility function!

@ajalt
Copy link
Owner

ajalt commented Sep 17, 2024

You can also always copy the old implementation if you want to use it now.

@cmdjulian
Copy link
Author

I did that, but it's a bit clumsy. Any progress so far?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants