Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting generation options on each pass #5

Open
ajbrown opened this issue Mar 7, 2016 · 0 comments
Open

Allow setting generation options on each pass #5

ajbrown opened this issue Mar 7, 2016 · 0 comments

Comments

@ajbrown
Copy link
Owner

ajbrown commented Mar 7, 2016

The http://namemachine.xyz API allows the specification of gender probability. Because of this, a new instance of NameGenerator has to be instantiated for each request, which means parsing the names files every since time.

This would be much more efficient if options could be specified each time. We could then keep one generator in application state.

To keep the API consistent and compatible, the current method of specifying options should set the default options that are used if options aren't specified for a particular invocation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant