This repository has been archived by the owner on Dec 31, 2022. It is now read-only.
Use revision-based deploy provider. #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajgon
pushed a commit
that referenced
this pull request
Oct 17, 2020
|
fixed build and merged |
ajgon
pushed a commit
that referenced
this pull request
Oct 17, 2020
|
Thanks - my testing approach was obviously broken but I’d run out of time to revisit it. |
dotnofoolin
pushed a commit
to dotnofoolin/opsworks_ruby
that referenced
this pull request
Nov 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recommended deploy provider up until total deprecation was
deploy_revisionwhich uses git reference, rather than timestamp, for the path. It's not the default for historical reasons and ISTR wasn't even available until opsworks_ruby recently imported the deploy_resource code.We'd found that the timestamped provider intermittently broke reproducible asset builds in our production cluster, in particular where Webpack output hash configurations were path-specific, since all the path slugs varied by a few seconds.
This is a simple-looking PR and already in production with us, but I'm aware it could be a major or breaking change for some folks.