Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing font-size in _typography causes horizontal bars to appear #10

Open
itsam opened this issue Jun 3, 2016 · 2 comments
Open

changing font-size in _typography causes horizontal bars to appear #10

itsam opened this issue Jun 3, 2016 · 2 comments

Comments

@itsam
Copy link

itsam commented Jun 3, 2016

Hi there. Amazing work! Keep going.
I am trying to make fonts bigger in baseline so I change font-size
@include breakpoint(xlarge) { font-size: 16pt; }

If I do that the content of the page does not fit well, causing a horizontal bar to appear.
Any ideas?

@itsam
Copy link
Author

itsam commented Jun 4, 2016

Problem found.

@include skel-layout((
        reset: 'full',
        boxModel: 'border',
        containers: 80em,
        grid: ( gutters: 2em ),
        breakpoints: (
            xlarge: (
                containers: 80%,
                grid: ( gutters: 1.5em )
            ),          
            large: (
                containers: 65em,
                grid: ( gutters: 1.5em )
            ),
            medium: (
                containers: 90%
            ),
            small: (
                containers: (90%, true),
                grid: ( gutters: 1.25em )
            ),
            xsmall: (
                containers: (90%, true),
                grid: ( gutters: 1.25em )
            )
        )
    ));

There are some missing breakpoints in main.scss... If it helps I can provide a pull request... Otherwise, please fix accordingly.

Thanks in advance.

@ajlkn
Copy link
Owner

ajlkn commented Oct 23, 2016

What's the context of @include breakpoint(xlarge) { font-size: 16pt; } ? Is it inside a rule targeting body or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants