Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittant failure of Fenwick tree removal #508

Closed
EdNoepel opened this issue Jan 6, 2023 · 1 comment
Closed

Intermittant failure of Fenwick tree removal #508

EdNoepel opened this issue Jan 6, 2023 · 1 comment

Comments

@EdNoepel
Copy link
Contributor

EdNoepel commented Jan 6, 2023 •
edited
Loading

Need to rework randomness function to base it on a deterministic seed. Afterword, we can run a continuous test to reproduce the behavior of failed removal, and further investigate the problem.

Details from the card
DSTest currently has this randomInRange facility which generates psuedorandomness by taking the keccak of block.timestamp, msg.sender, and _nonce. The block timestamp and nonce are not deterministic, hindering reproduction of fuzz test failures.

Create a new random function which takes a fuzzed seed, and move consumers over to this function as failures are observed. First subject is FenwickTreeInstance.fuzzyFill.
@EdNoepel
Copy link
Contributor Author

EdNoepel commented Jan 8, 2023

Seems this was an issue with the fuzz tests, not the Fenwick tree itself. Will be fixed by #523 once upstream PRs are merged.

@EdNoepel EdNoepel closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EdNoepel