Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grgit-gradle should have api dependency on grgit-core #267

Closed
SUPERCILEX opened this issue Nov 13, 2018 · 0 comments
Closed

grgit-gradle should have api dependency on grgit-core #267

SUPERCILEX opened this issue Nov 13, 2018 · 0 comments

Comments

@SUPERCILEX
Copy link
Contributor

SUPERCILEX commented Nov 13, 2018 •
edited by ajoberstar
Loading

(edit by @ajoberstar) As of Gradle 5.0, Maven publications do not expose implementation dependencies on the compile classpath of their published POM files. Since consumers of grgit-gradle almost definitely need to interact with Grgit types, the grgit-core dependency should be in the api configuration.

See gradle/gradle#7710 (comment)
@ajoberstar ajoberstar changed the title Include core dependency in compile classpath grgit-gradle should have api dependency on grgit-core Nov 13, 2018
@ajoberstar ajoberstar mentioned this issue Jan 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SUPERCILEX