December 12-18, 2021 in Darker: Configuration Challenges and VSCode Integration #668
akaihola
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This week, we addressed configuration challenges in mono-repository setups and explored improvements for VSCode integration. A regression in configuration handling was identified (#244), affecting projects with complex directory structures. The issue stems from changes in how Darker locates and loads configuration files, potentially causing it to miss the root
pyproject.toml
containing project-wide settings. While a temporary workaround using pre-commit configuration was suggested, we're considering more robust solutions to restore previous behavior or introduce a new option for specifying the config file path.On the IDE integration front, we investigated an issue affecting VSCode's "format on save" functionality (#249). The problem arises from Darker's file filtering mechanism, which excludes temporary files created by VSCode before checking for matching tracked files. A community member proposed a potential fix by modifying the
should_reformat_file
function to consider the original file's extension rather than the temporary file's name. This change could improve Darker's compatibility with VSCode and potentially other IDEs that use similar temporary file mechanisms for formatting.Beta Was this translation helpful? Give feedback.
All reactions