Just Some Color Inconsistency

[ryanagillie]

Hello! I noticed some color inconsistencies between the theme and Atom. This is just me being picky, but I thought I should still send something in :)
I know VSCode doesn't give as much control over colors as Atom, but just in case some of this does overlap, I thought I should throw these in here.

To begin, the variable colors are wrong with the const variable name. In Atom, the const variable name has the color #c99c67 or #c99c68 (depending on which pixel you choose to eyedropper). let and var share the same color, it's just that const is different.

The second photo has the same issue as the first, as well as the Discord does not share the same color orange(yellow?) as .Client.
I believe that the entire Discord.Client should be the color #e0c17b

With the third photo, the regex /'s are blue, not green.

The fourth photo has the same issue as the third, with the addition that the regex g is purple and not cyan. (This one I don't mind that much, imo it's easier to see the g as purple, but atom has it as cyan)

The last and final photo, the roleToAdd is white and not green.

This is everything that I have found so far. If there is anything else, I will make sure to let you know!

Sample code

const maybe;
var yes;
let no;

const Discord = require('discord.js');
const client = new Discord.Client();

if (/^\d+$/.test(command) || /\$+/.test(command)) return;

const argNoTag = arg.replace(/<@?!?\D+\d+>/g, '').trim();

message.channel.send(`${message.member.user}, I have removed the role \`${roleToAdd}\`.`);

Filename and Language selected

File extension - .js
Language - JavaScript

Atom Original theme Screenshot

VSCode theme Screenshot

Versions used

• VSCode version: 1.20.1
• Theme version: 2.1.0

[akamud]

Thank you so much for submitting this. Being "picky" is what makes this port be the best rated in the marketplace, so you shouldn't feel bad for submitting this ;)

A few of these have come up before, like the const, it is by far the most reported inconsistency here. Unfortunately, it is a limitation from the tmLanguage used in JS/TS and Microsoft believes it doesn't have enough value to be fixed, so feel free to ask for a fix in Typescript-tmLanguage.

I'll look into the other ones and provide a fix or a explanation if they are not fixable.

[ryanagillie]

It's been a few months and VSCode has changed quite a bit since my post. It seems the const issue was fixed. The only thing I've noticed is that now you can access the regex //'s by using the string.regexp property

[akamud]

Awesome news, thanks again for your work. I'm having trouble finding time to update the project. I'll let you know when I release a new version.