Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Contributing Experience #14

Open
2 of 3 tasks
akinncar opened this issue Jun 8, 2021 · 0 comments
Open
2 of 3 tasks

Improve Contributing Experience #14

akinncar opened this issue Jun 8, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@akinncar
Copy link
Owner

akinncar commented Jun 8, 2021

Related: callstack/react-native-builder-bob#177

We need to dynamic change main file of package.json depending on the environment. The case is that currently, we need to run yarn prepare on all changes to re-compile on development mode how you can see on CONTRIBUTING.MD

Our compiled build goes to lib/ folder and our source code is on src/ folder, but the main file on package.json only calls lib/folder.

See callstack/react-native-builder-bob#177 to get more context
Also: https://twitter.com/akinncar/status/1400468779318927361

Update

This issue is partially solved in #44
The next step is to allow example app to work with Web (now it is working only with Android and iOS).

  • iOS
  • Android
  • Web
@akinncar akinncar added enhancement New feature or request help wanted Extra attention is needed labels Jun 8, 2021
@akinncar akinncar self-assigned this Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant