Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel sliding while drag-scrolling vertically on a touch device #598

Closed
semenets opened this issue Jan 7, 2017 · 19 comments
Closed

Carousel sliding while drag-scrolling vertically on a touch device #598

semenets opened this issue Jan 7, 2017 · 19 comments
Labels

Comments

@semenets
Copy link

semenets commented Jan 7, 2017

Link to original issue: kenwheeler/slick#2521

In the link above you can see description of the bug. I think it's very important to fix that in react-slick too. So can we merge that changes in react-slick? I am ready to do that, if @akiran or somebody else accept this idea.

@vitalim
Copy link

vitalim commented Jan 9, 2017

I agree with semenets - I think it's important - struggling with it as well on my app

@ghost
Copy link

ghost commented Mar 16, 2017

Any update on this issue? I am worried about this issue. Please give a solution for this.

@ghost
Copy link

ghost commented Mar 16, 2017

Anybody have solution for this issue on react-slick node_modules?

@vijaybarnwal
Copy link

Any update on this?????

@vitalim
Copy link

vitalim commented Mar 16, 2017

Try this for now:
https://www.npmjs.com/package/react-slick-with-mobile-in-mind
Thanks to semenets

@vijaybarnwal
Copy link

Vitalim, What is the changes you have made in given package? Any changes required for settings in slider tag?

@vijaybarnwal
Copy link

Hi semenets,

Can you please guide me is any change required for settings in slider tag?

Thanks,
Vijay

@vijaybarnwal
Copy link

Vitalim, Is it working for you?

@vitalim
Copy link

vitalim commented Mar 16, 2017

Yes, I'm using it just like the regular react-slick

@vijaybarnwal
Copy link

Have you pass any parameter to slider settings for this issue?

@vitalim
Copy link

vitalim commented Mar 16, 2017

This is the settings i'm using:
const settings = {
arrows: false,
infinite: false,
}

@vijaybarnwal
Copy link

I am getting same issue when scrolling vertically carousal moves/slides horizontally.

Is any fix have you done in https://www.npmjs.com/package/react-slick-with-mobile-in-mind?

Thanks,
Vijay

@naltatis
Copy link

The pull request has just been merged in original slick. Can someone port it?

@hustlerism
Copy link

Having the same issue as well in my Mobile App.

@ryota-murakami
Copy link

I pushed the changes I made to solve this problem in my application to PR.
Please review if it is possible. Thanks!

@stale
Copy link

stale bot commented Mar 24, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 24, 2018
@stale stale bot closed this as completed Mar 31, 2018
@emphaticsunshine
Copy link

I see the issue is closed but was it resolved?

@ryota-murakami
Copy link

@emphaticsunshine I've submitted PR about 2 and half years ago.
According to the comment, this is fixed version 0.22.2 later.

@paulcpk
Copy link

paulcpk commented Mar 5, 2020

Possible duplicate: #1240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants