Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide @mentions setting on Edit User page doesn't work #283

Closed
mikewmerritt opened this issue Jan 19, 2024 · 1 comment · Fixed by #289
Closed

Hide @mentions setting on Edit User page doesn't work #283

mikewmerritt opened this issue Jan 19, 2024 · 1 comment · Fixed by #289

Comments

@mikewmerritt
Copy link

mikewmerritt commented Jan 19, 2024

I've noticed this setting on Edit User (edit-friend) doesn't work. I thought it's possible it's extraneous since the identical setting on Edit Feeds (edit-friend-feeds) does work.

Looking further, I see the activitypub_save_settings() function in class-feed-parser-activitypub.php and do_action callback friends_edit_friend_after_form_submit within process_admin_edit_friend_feeds() in class-admin.php seem to be expecting the setting to be part of the Edit Feeds page.

@akirk
Copy link
Owner

akirk commented Feb 7, 2024

Thank you! This will be fixed in Friends 2.8.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants