Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV line scanner skipping final line when last column is empty in 1.0.1 #1710

Closed
RoccoMathijn opened this issue May 20, 2019 · 2 comments
Closed
Labels
Milestone

Comments

@RoccoMathijn
Copy link

RoccoMathijn commented May 20, 2019

With version 1.0.1 of Alpakka CSV the line scanner skips the final line when the last line does not have a line ending and the last column in this line is empty.

I've recreated the issue using the demo app from kciesielski from this slightly related issue: #315

With 1.0.0 both of the tests succeed. With 1.0.1 the last one fails.
https://github.com/RoccoMathijn/akka-quickstart-scala/blob/master/src/test/scala/com/lightbend/akka/sample/CsvTest.scala

edit: I simplified some things in the issue. First I thought the problem only occurred when the last line had a column less than the rest AND the last column was empty. But the number of columns doesn't seem to matter.

@RoccoMathijn RoccoMathijn changed the title CSV line scanner skipping final line in 1.0.1 CSV line scanner skipping final line when last column is empty in 1.0.1 May 20, 2019
@ennru ennru added the p:csv label May 21, 2019
@ennru
Copy link
Member

ennru commented May 21, 2019

Thank you for reporting, this must have been introduced by the optimisations in #1685.

@ennru ennru added this to the 1.0.2 milestone May 21, 2019
@ennru
Copy link
Member

ennru commented May 23, 2019

Fixed with #1711

@ennru ennru closed this as completed May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants