Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BigQuery] Add extra params to the QueryRequest #2679

Merged
merged 7 commits into from
May 29, 2021
Merged

[BigQuery] Add extra params to the QueryRequest #2679

merged 7 commits into from
May 29, 2021

Conversation

kovstas
Copy link
Contributor

@kovstas kovstas commented May 25, 2021

I want to add extra params to the BigQuery query request.

  • location the geographic location where the job should run
  • maximumBytesBilled limits the number of bytes billed for this query

These params described here https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs/query#QueryRequest

References #xxxx

ennru
ennru reviewed May 26, 2021
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for suggesting this.

...gquery/src/main/scala/akka/stream/alpakka/googlecloud/bigquery/model/QueryJsonProtocol.scala Outdated Show resolved Hide resolved
armanbilge
armanbilge reviewed May 28, 2021
View reviewed changes
Copy link
Contributor

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these!

While you are making these changes, would you mind adding labels: Map[String, String] as well? I think it's another useful param.

...gquery/src/main/scala/akka/stream/alpakka/googlecloud/bigquery/model/QueryJsonProtocol.scala Outdated Show resolved Hide resolved
@kovstas
Copy link
Contributor Author

kovstas commented May 28, 2021

Thanks for adding these!

While you are making these changes, would you mind adding labels: Map[String, String] as well? I think it's another useful param.

Ok, I think so) I've added it.

armanbilge
armanbilge approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking my suggestions :)

@kovstas kovstas requested a review from ennru May 29, 2021 15:10
ennru
ennru approved these changes May 29, 2021
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit 0153ae7 into akka:master May 29, 2021
@ennru ennru added this to the 3.0.1 milestone May 29, 2021
@kovstas kovstas deleted the extend-request-entity-big-query-connector branch May 29, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
p:google-cloud-bigquery
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@kovstas @ennru @armanbilge