Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassandra: pick current Jackson version #2923

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

ennru
Copy link
Member

@ennru ennru commented Oct 12, 2022

Ensure Alpakka Cassandra uses the current version of Jackson.
(java-driver-core 4.14.1 brings in 2.13.2)

@probot-autolabeler probot-autolabeler bot added the dependency-change For PRs changing the version of a dependency. label Oct 12, 2022
@@ -108,7 +108,7 @@ object Dependencies {
.exclude("org.apache.tinkerpop", "*") //https://github.com/akka/alpakka/issues/2200
.exclude("com.esri.geometry", "esri-geometry-api"), //https://github.com/akka/alpakka/issues/2225
"com.typesafe.akka" %% "akka-discovery" % AkkaVersion % Provided
)
) ++ JacksonDatabindDependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment would be good, because it's not obvious why we would add Jackson dependency here or that the driver has the Jackson dependency

@ennru ennru merged commit 24e2f56 into akka:master Oct 12, 2022
@ennru ennru deleted the ennru-cassandra-jackson branch October 12, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-change For PRs changing the version of a dependency. p:cassandra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants