bump: Scala 2.13.10 and 2.12.17; Javadoc links #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
dependency-change
|
Scala introduced more warnings which now make the build fail. |
He-Pin
reviewed
Oct 13, 2022
| @@ -552,7 +552,7 @@ trait S3IntegrationSpec | |||
| _ <- akka.pattern.after(25.seconds)(Future { | |||
| sharedKillSwitch.abort(AbortException) | |||
| }) | |||
| _ <- multiPartUpload.recover { | |||
| _ <- multiPartUpload.recover[Any] { | |||
There was a problem hiding this comment.
val defaultScalaOptions = "-Wconf:cat=unused-nowarn:s,cat=lint-infer-any:s,any:e"
is used in Akka akka/akka#31648
patriknw
reviewed
Oct 14, 2022
| @@ -89,7 +89,7 @@ class AmqpGraphStageLogicConnectionShutdownSpec | |||
|
|
|||
| Future | |||
| .traverse(input)(in => Source.single(ByteString(in)).runWith(amqpSink)) | |||
| .recover { | |||
| .recover[Object] { | |||
| @@ -61,7 +61,7 @@ class InfluxDbSourceSpec | |||
| val query = new Query("SELECT man() FROM invalid", DatabaseName); | |||
|
|
|||
| val result = InfluxDbSource(influxDB, query) //.runWith(Sink.seq) | |||
| .recover { | |||
| .recover[Object] { | |||
| "http://www.scala-lang.org/api/2.13.8/scala/concurrent/Future.html" | ||
| "http://www.scala-lang.org/api/2.13.8/scala/util/Try.html" | ||
| "http://www.scala-lang.org/api/2.13.10/scala/concurrent/Future.html" | ||
| "http://www.scala-lang.org/api/2.13.10/scala/util/Try.html" |
There was a problem hiding this comment.
There was a problem hiding this comment.
Sadly not. The generated links contain the exact version.
|
I updated the mocks in Google Pub/Sub so they don't always fail. |
ennru
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and remove some link checking left-overs.