Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mongo: driver 4.7.2 (was 4.4.0), adds full support for MongoDB 6.0 #2940

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Mongo: driver 4.7.2 (was 4.4.0), adds full support for MongoDB 6.0 #2940

merged 2 commits into from
Dec 8, 2022

Conversation

mikela
Copy link
Contributor

@mikela mikela commented Nov 13, 2022

@lightbend-cla-validator
Copy link

Hi @mikela,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

@probot-autolabeler probot-autolabeler bot added the dependency-change For PRs changing the version of a dependency. label Nov 13, 2022
@mikela
Copy link
Contributor Author

mikela commented Nov 13, 2022

Signed

@ennru
Copy link
Member

ennru commented Nov 15, 2022

It looks like some warnings do not apply anymore:

[error] /home/runner/work/alpakka/alpakka/mongodb/src/test/scala/docs/scaladsl/MongoSinkSpec.scala:42:101: @nowarn annotation does not suppress any warnings
[error]     fromRegistries(fromProviders(classOf[Number], classOf[DomainObject]), DEFAULT_CODEC_REGISTRY): @nowarn(
[error]                                                                                                     ^
[error] /home/runner/work/alpakka/alpakka/mongodb/src/test/scala/docs/scaladsl/MongoSourceSpec.scala:54:52: @nowarn annotation does not suppress any warnings
[error]     fromRegistries(fromProviders(classOf[Number]: @nowarn("msg=match may not be exhaustive")), DEFAULT_CODEC_REGISTRY)
[error]                                                    ^
[error] two errors found

@ennru ennru changed the title Mongo: Update to latest driver, which adds full support for MongoDB 6.0 Mongo: driver 4.7.2 (was 4.4.0), adds full support for MongoDB 6.0 Dec 8, 2022
ennru
ennru approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit 56c8ced into akka:master Dec 8, 2022
@ennru
Copy link
Member

ennru commented Dec 8, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
dependency-change For PRs changing the version of a dependency. p:mongodb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikela @lightbend-cla-validator @ennru