Scala3 builds csv, cassandra, testkit

[sebastian-alfers]

No description provided.

[johanandren]

Do we need to add something in ci config to compile the supported modules with Scala 3 on PR/nightlies as well?

[sebastian-alfers]

Do we need to add something in ci config to compile the supported modules with Scala 3 on PR/nightlies as well?

I am not sure if we run nightlies, do we? At least I did not see it.

Re scala3 in PRs, I got the understanding that we only want scala3 (same for 2.12) to be used during cros publishing. At least this is how it is right now for the scla3 builds I was working on.

[patriknw]

Re scala3 in PRs, I got the understanding that we only want scala3 (same for 2.12) to be used during cros publishing. At least this is how it is right now for the scla3 builds I was working on.

We should at minimum compile with all Scala versions. We typically do that with +Test/compile. That should be changed here

alpakka/.github/workflows/check-build-test.yml

Line 45 in 5228417

run: sbt +~2.13 "verifyCodeStyle; Test/compile; mimaReportBinaryIssues"

It's probably obsolete to use 2.13 there, since 2.13 is the default version.

Also, currently I think we run tests with the default 2.13, which is good, but it means that we currently don't build with 2.12 at all (unless I missed something, didn't look so close). Anyway, that is fixed by compiling with +Test/compile.

[sebastian-alfers]

Makes sense, will review.

[sebastian-alfers]

Something is off with CI, it does not succeed and I can not cancel it...

[johanandren]

Looks like that worked nicely (I see 3.1 in the Compile, Code Style, Binary Compatibility check), looks like the label/name of the job/step is still wrong though.

[johanandren]

LGTM!

I tried out a +publishLocal to double check that package/docs work fine as well and that looks good.