Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTP: Add for FTPS the ability to set KeyManager and TrustManager #2993

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

TheDeadOne
Copy link
Contributor

This fix adds a couple of methods to FtpsSettings to set specific KeyManager and TrustManager.

I understand that the old tag is taken as a basis, but it would be nice to release, for example, version 2.1 with this improvement.

@probot-autolabeler probot-autolabeler bot added p:ftp dependency-change For PRs changing the version of a dependency. labels Jul 28, 2023
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for suggesting, this addition could go into Alpakka 6.0.4.
Please rebase it.

ftp/src/main/scala/akka/stream/alpakka/ftp/model.scala Outdated Show resolved Hide resolved
@TheDeadOne
Copy link
Contributor Author

@ennru I hope everything is done right.

@ennru
Copy link
Member

ennru commented Aug 25, 2023

One more thing...

[error] akka-stream-alpakka-ftp: Failed binary compatibility check against com.lightbend.akka:akka-stream-alpakka-ftp_2.13:6.0.2! Found 1 potential problems
[error]  * method this(java.net.InetAddress,Int,akka.stream.alpakka.ftp.FtpCredentials,Boolean,Boolean,scala.Function1,scala.Option)Unit in class akka.stream.alpakka.ftp.FtpsSettings does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("akka.stream.alpakka.ftp.FtpsSettings.this")

It is fine to add an exclusion as the constructor is actually private but Mima doesn't see that.

The filter should go into a file in ftp/src/main/mima-filters/6.0.3.backwards.excludes.

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you!

@ennru ennru merged commit cf024cd into akka:main Aug 25, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-change For PRs changing the version of a dependency. p:ftp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants