Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: Scala 2.13.12 (was 2.13.10) #3027

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Conversation

ennru
Copy link
Member

@ennru ennru commented Oct 20, 2023

@probot-autolabeler probot-autolabeler bot added the dependency-change For PRs changing the version of a dependency. label Oct 20, 2023
@ennru ennru marked this pull request as draft October 20, 2023 15:14
@ennru
Copy link
Member Author

ennru commented Oct 20, 2023

Needs a few fixes to the sources.

@@ -23,7 +23,7 @@ import scala.util.Random
abstract class GCStorageWiremockBase(_system: ActorSystem, _wireMockServer: Hoverfly) extends TestKit(_system) {

def this(mock: Hoverfly) =
this(ActorSystem(getCallerName(getClass),
this(ActorSystem(getCallerName(GCStorageWiremockBase.getClass),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classOf[GCStorageWiremockBase] ?

@ennru ennru marked this pull request as ready for review October 23, 2023 08:35
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ennru ennru merged commit ff322ae into akka:main Oct 23, 2023
48 of 49 checks passed
@ennru ennru deleted the ennru-scala-2.13.12 branch October 23, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants