Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Spray JWT dependency #3030

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Replace Spray JWT dependency #3030

merged 3 commits into from
Oct 24, 2023

Conversation

ennru
Copy link
Member

@ennru ennru commented Oct 24, 2023

Remove the dependency on com.github.jwt-scala jwt-spray-json which was discontinued.

Add the relevant sources from that library into google-common which was the only Alpakka part relying in this.

References

@probot-autolabeler probot-autolabeler bot added the dependency-change For PRs changing the version of a dependency. label Oct 24, 2023
patriknw
patriknw approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ennru ennru merged commit 917822f into akka:main Oct 24, 2023
47 of 48 checks passed
@ennru ennru deleted the ennru-spray-jwt-json branch October 24, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

Assignees
No one assigned
Labels
dependency-change For PRs changing the version of a dependency. p:google-common p:huawei-push-kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ennru @patriknw