Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: Rollback sbt to 1.9.6 #3128

Merged
merged 3 commits into from
Feb 26, 2024
Merged

bump: Rollback sbt to 1.9.6 #3128

merged 3 commits into from
Feb 26, 2024

Conversation

johanandren
Copy link
Member

Strange issues in main on 1.9.9 where javax.jms cannot be found. We did not manage to reproduce that locally, but consistently happens in ghactions.

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ennru
Copy link
Member

ennru commented Feb 26, 2024

Same error with JMS classes. 🤔

@johanandren johanandren changed the title bump: Rollback sbt to 1.9.8 bump: Rollback sbt to 1.9.7 Feb 26, 2024
@johanandren johanandren changed the title bump: Rollback sbt to 1.9.7 bump: Rollback sbt to 1.9.6 Feb 26, 2024
@johanandren
Copy link
Member Author

Ok, so something with 1.9.7 is the problem. But that's where the recent security fix is and we'd want that. Not obvious from the release notes what could cause it but there is a coursier bump in there: https://github.com/sbt/sbt/releases/tag/v1.9.7

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Will require some digging.
Test failure is unrelated.
LGTM.

@ennru ennru merged commit 2aa5505 into main Feb 26, 2024
49 of 50 checks passed
@ennru ennru deleted the wip-rollback-sbt-199 branch February 26, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants