Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MySqlConnector for async I/O #22

Closed
bgrainger opened this issue Jan 27, 2018 · 3 comments
Closed

Use MySqlConnector for async I/O #22

bgrainger opened this issue Jan 27, 2018 · 3 comments

Comments

@bgrainger
Copy link

The AbstractQueryExecutor code uses ExecuteReaderAsync. It's a long-standing bug in MySql.Data (bug 70111) that the async I/O methods are not implemented; thus all these methods will fall back to running synchronously. (See also here and here on Stack Overflow.)

To fix this, you could switch to https://github.com/mysql-net/MySqlConnector, an OSS replacement for MySql.Data that supports true asynchronous I/O.

If you're interested in this, I'd be happy to open a PR.

@marcosArruda
Copy link

+1

@bgrainger
Copy link
Author

Another reason to switch (which https://aaronstannard.com/opentelemetry-dotnet6/ just reminded me of) would be tracing: MySqlConnector implements ActivitySource (mysql-net/MySqlConnector#1036) and could be more easily integrated with other OTel tracing provided by Akka.

@Arkatufus
Copy link
Contributor

Issue resolved in MySql.Data version 8.0.33
https://dev.mysql.com/doc/relnotes/connector-net/en/news-8-0-33.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants