Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing DoNotInherit annotation #4883

Closed
ismaelhamed opened this issue Mar 30, 2021 · 1 comment · Fixed by #4896
Closed

Missing DoNotInherit annotation #4883

ismaelhamed opened this issue Mar 30, 2021 · 1 comment · Fixed by #4896

Comments

@ismaelhamed
Copy link
Member

Is there a reason why DoNotInherit is missing from the annotations? I can see it all over the place in the JVM. Would a PR be fine?

/// <summary>
/// <para>
/// Marks APIs that are designed under a closed-world assumption for and are NOT meant to be
/// extended by user-code. It is fine to extend these classes within Akka itself however.
/// </para>
/// <para>
/// This is most useful for binary compatibility purposes when a set of classes and interfaces
/// assume a "closed world" between them, and gain the ability to add methods to the interfaces
/// without breaking binary compatibility for users of this code. Specifically this assumption may be
/// understood intuitively: as all classes that implement this interface are in this compilation unit
/// artifact, it is impossible to obtain a "old" class with a "new" interface, as they are part of
/// the same dependency.
/// </para>
/// </summary>
[AttributeUsage(AttributeTargets.Class | AttributeTargets.Interface)]
public sealed class DoNotInheritAttribute: Attribute
{
}
@Aaronontheweb
Copy link
Member

Yep, a PR would be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants