Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Markdown linting for the docs #5312

Closed
29 tasks done
SeanKilleen opened this issue Oct 14, 2021 · 7 comments · Fixed by #5345
Closed
29 tasks done

Add Markdown linting for the docs #5312

SeanKilleen opened this issue Oct 14, 2021 · 7 comments · Fixed by #5345
Labels
Milestone

Comments

@SeanKilleen
Copy link
Contributor

SeanKilleen commented Oct 14, 2021

One of my initial goals for #5309 was to implement both spellcheck and markdown linting for the docs, but there were just too many changes there. Best to go one bite at a time.

Game Plan

  • Examine markdown linting with some standard rules in place from NUnit
  • Enumerate a list of thematic changes here in this issue
  • Tackle all the linting changes in thematic PRs
  • (Markdown linting: build steps and last fixes #5345) Add markdownlint rules and Azure DevOps task to run the linting (which should, if all goes well, pass shortly thereafter)

My Approach

  • Create markdownlint settings files (.markdownlintrc and .markdownlint.json)
  • Disable all rules ("default": false in the config)
  • Enable one tag or rule at a time
  • Work through those items in a PR -- where possible, using VSCode tooling to apply fixes per file.

Hoping this will keep things consistent and thematic and therefore easier to review and discuss.

Local Tooling

  • npm install -g markdownlint-cli
  • markdownlint "docs/**/*.md"

Items to Tackle

Themes / tags -- taken from markdownlint site -- I may break these up smaller as warranted:

@SeanKilleen
Copy link
Contributor Author

SeanKilleen commented Oct 14, 2021

A side note on this -- I'm explaining my rationale, process, and tooling here because I think others may want to get involved and this is a relatively straightforward thing to work on. If anyone is interested, tag me here and I'll be happy to give you any walkthrough to get you up and running to contribute to the effort.

@sean-gilliam
Copy link
Member

Great stuff man

@SeanKilleen
Copy link
Contributor Author

Once the 5 outstanding PRs are merged, we can move onto the next batch. I think there will be too many conflicts to try to proceed with the other items in parallel.

@SeanKilleen
Copy link
Contributor Author

At the next stopping point. I think Once the 3 outstanding PRs are merged, can continue onto the following topics.

@SeanKilleen
Copy link
Contributor Author

OK, we're in a pretty good place here.

I think once the last linting PR on headings is merged, I should be able to do the last PR which will introduce the actual checking, the ignore files, etc.

@SeanKilleen
Copy link
Contributor Author

Last PR! 🎉 Everything looks to be in order, so I think this issue will be closed entirely soon.

@Aaronontheweb Aaronontheweb added this to the 1.4.28 milestone Oct 25, 2021
@Aaronontheweb
Copy link
Member

Well done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants