-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Markdown linting for the docs #5312
Comments
A side note on this -- I'm explaining my rationale, process, and tooling here because I think others may want to get involved and this is a relatively straightforward thing to work on. If anyone is interested, tag me here and I'll be happy to give you any walkthrough to get you up and running to contribute to the effort. |
Great stuff man |
Once the 5 outstanding PRs are merged, we can move onto the next batch. I think there will be too many conflicts to try to proceed with the other items in parallel. |
At the next stopping point. I think Once the 3 outstanding PRs are merged, can continue onto the following topics. |
OK, we're in a pretty good place here. I think once the last linting PR on headings is merged, I should be able to do the last PR which will introduce the actual checking, the ignore files, etc. |
Last PR! 🎉 Everything looks to be in order, so I think this issue will be closed entirely soon. |
Well done. |
One of my initial goals for #5309 was to implement both spellcheck and markdown linting for the docs, but there were just too many changes there. Best to go one bite at a time.
Game Plan
My Approach
.markdownlintrc
and.markdownlint.json
)"default": false
in the config)Hoping this will keep things consistent and thematic and therefore easier to review and discuss.
Local Tooling
npm install -g markdownlint-cli
markdownlint "docs/**/*.md"
Items to Tackle
Themes / tags -- taken from markdownlint site -- I may break these up smaller as warranted:
line_length - MD013(ignored)The text was updated successfully, but these errors were encountered: