Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SetHandler method that accepts an Inlet and an Outlet to SetHandlers #5921

Closed
ismaelhamed opened this issue May 6, 2022 · 3 comments · Fixed by #5931
Closed

Rename SetHandler method that accepts an Inlet and an Outlet to SetHandlers #5921

ismaelhamed opened this issue May 6, 2022 · 3 comments · Fixed by #5931

Comments

@ismaelhamed
Copy link
Member

Version Information
Akka 1.4.37
Akka Streams

Describe the issue
Method SetHandler that accepts both an Inlet and an Outlet should be named SetHandlers (plural). This looks like a small typo, but it made me think we didn't have that feature implemented when I first looked.

@Aaronontheweb
Copy link
Member

Do we just need to add a new overload to do this?

@ismaelhamed
Copy link
Member Author

In order to avoid a breaking change we could add a new method with the correct name (SetHandlers) and deprecate the current one.

BTW, and you guys have probably already thought about this, but prior to releasing Akka.NET 1.5 it might be a good idea doing some cleanup and removing most of the methods already marked as Obsolete. Otherwise I don't think it's ever going to happen ;)

@Aaronontheweb
Copy link
Member

@ismaelhamed

BTW, and you guys have probably already thought about this, but prior to releasing Akka.NET 1.5 it might be a good idea doing some cleanup and removing most of the methods already marked as Obsolete. Otherwise I don't think it's ever going to happen ;)

100% - planning on deleting the old MNTR and Akka.DI libraries next week, for starters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants