Resolve Akka.Delivery and Akka.Cluster.Sharding.Delivery issues #7538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix akkadotnet#7529, Fix akkadotnet#7530: Fix ShardingProducerController and RetryTimer issues - Fix akkadotnet#7529: Update ShardingProducerController to return sequence numbers instead of Done.Instance in AskNextTo responses to match Task<long> return type - Fix akkadotnet#7530: Properly store and increment RetryTimer interval in ScheduleNext() method to enable exponential backoff This commit addresses two issues in the Akka.Cluster.Sharding.Delivery module: 1. Fixes type mismatch in ShardingProducerController where AskNextTo was returning Done.Instance instead of the expected sequence number 2. Fixes RetryTimer not properly incrementing intervals by storing the new interval value before starting the timer
Aaronontheweb
commented
Mar 19, 2025
Member
Author
Aaronontheweb
left a comment
Aaronontheweb
left a comment
There was a problem hiding this comment.
Detailed my changes
| case (_, _, { IsEmpty: false } replyTo): | ||
| replyTo.Value.Tell(Done.Instance); | ||
| case (_, outSeqNr, { IsEmpty: false } replyTo): | ||
| replyTo.Value.Tell(outSeqNr); // Send the sequence number instead of Done.Instance |
Member
Author
There was a problem hiding this comment.
Reply with the seqNo instead of Task.Done
| if (newInterval != Interval) | ||
| { | ||
| Interval = newInterval; // Store the new interval | ||
| Timers.StartPeriodicTimer(Retry.Instance, Retry.Instance, newInterval); |
Member
Author
There was a problem hiding this comment.
Use the correct backoff interval
Aaronontheweb
commented
Mar 19, 2025
|
|
||
| // expecting 3 end messages, one for each entity: "entity-0", "entity-1", "entity-2" | ||
| await consumerEndProbe.ReceiveNAsync(3, TimeSpan.FromSeconds(5)).ToListAsync(); | ||
| await consumerEndProbe.ReceiveNAsync(3, TimeSpan.FromSeconds(10)).ToListAsync(); |
Member
Author
There was a problem hiding this comment.
This test was racy so I took a look at the build logs and the issue was just that we didn't quite get through the 40ish messages we need to send for this assertion to pass, I assume because the Azure DevOps box is pretty tiny. Expanded the timeout here to give it a fighting chance.
This was referenced Mar 21, 2025
This was referenced Sep 4, 2025
This was referenced Oct 7, 2025
This was referenced Oct 7, 2025
This was referenced Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #7529, Fix #7530: Fix ShardingProducerController and RetryTimer issues
This commit addresses two issues in the Akka.Cluster.Sharding.Delivery module:
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):