Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement callback that is called after parent build is completed #219

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

alvkn
Copy link
Contributor

@alvkn alvkn commented Nov 8, 2024

I want to have some post-build actions executed as a part of serve of build process, and as I can see there is no such possibility yet (described here #218). I was unable to achieve that using both plugins (they are executed for every entrypoint group, which is not the case) and rollup hook overrides.

So, I've added onBundleReady callback to the options, which is called for every extension rebuild.

onBundleReady?: void | Promise<void>

Feedback are welcome, I am ready to improve API or something else

Copy link
Owner

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR! Will merge once checks pass.

@aklinker1 aklinker1 changed the title Implement callback that called after parent build is completed feat: Implement callback that called after parent build is completed Nov 13, 2024
@aklinker1 aklinker1 changed the title feat: Implement callback that called after parent build is completed feat: Implement callback that is called after parent build is completed Nov 13, 2024
@aklinker1 aklinker1 merged commit c168303 into aklinker1:main Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants