fix: onBundleReady called before manifest is generated in build mode #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklinker1
changed the title
aklinker1
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one issue in #219 that causes the newly introduced
onBundleReadycallback to be called before the manifest is generated (as a file). The root cause of this issue is thatrollup.emitFile(which is used for build mode) only marks the file, and actually all the files are created as a part of thegenerateBundlehook. To ensure that all the files are already exist inoutDir, the flow has been updated to callonBundleReadyfrom thewriteBundlehook for build mode. Dev mode is not affected.