Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zilla is validating env vars before replacing them. #795

Closed
vordimous opened this issue Feb 13, 2024 · 1 comment · Fixed by #797 or #798
Closed

Zilla is validating env vars before replacing them. #795

vordimous opened this issue Feb 13, 2024 · 1 comment · Fixed by #797 or #798
Assignees
Labels
bug Something isn't working

Comments

@vordimous
Copy link
Contributor

Describe the bug
Zilla is validating env vars before replacing them.

[23,31][/telemetry/exporters/prometheus_metric_exporter/options/endpoints/0/port] The value must be of integer type, but actual type is string.
error
io.aklivity.zilla.runtime.engine.config.ConfigException: Engine configuration failed

To Reproduce

docker run -v ./zilla.yaml:/etc/zilla/zilla.yaml --env PORT="7190" ghcr.io/aklivity/zilla:0.9.68 start -v

zilla.yaml

---
name: example
bindings:
  north_tcp_server:
    type: tcp
    kind: server
    options:
      host: 0.0.0.0
      port: 12345
    exit: north_echo_server
  north_echo_server:
    type: echo
    kind: server

telemetry:
  exporters:
    prometheus_metric_exporter:
      type: prometheus
      options:
        endpoints:
          - scheme: http
            path: /metrics
            port: ${{env.PORT}}
@vordimous
Copy link
Contributor Author

vordimous commented Feb 14, 2024

Looks like this just fixed one issue. Running the redpanda-doom-demo has a vailed validation on the sasl.mechanism though the env variable is a valid value.

Exactly one of the following sets of problems must be resolved.
1) [116,51][/bindings/south_redpanda_client/options/sasl/mechanism] The value must be constant string "plain".
2) [116,51][/bindings/south_redpanda_client/options/sasl/mechanism] The value must be constant string "scram-sha-1".
3) [116,51][/bindings/south_redpanda_client/options/sasl/mechanism] The value must be constant string "scram-sha-256".
4) [116,51][/bindings/south_redpanda_client/options/sasl/mechanism] The value must be constant string "scram-sha-512".
error
io.aklivity.zilla.runtime.engine.config.ConfigException: Engine configuration failed

Perhaps any zilla.yaml property that has a restricted value could have this issue when it is set via an env var?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants