Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnMediaQueryChange Listeners not being removed onDestroy. #35

Closed
nicoabie opened this issue Mar 7, 2014 · 2 comments
Closed

OnMediaQueryChange Listeners not being removed onDestroy. #35

nicoabie opened this issue Mar 7, 2014 · 2 comments
Labels
bug

Comments

@nicoabie
Copy link

nicoabie commented Mar 7, 2014

Steps to reproduce it.

  1. Create an app with two partials.
  2. Use deckgrid in one of them.
  3. Switch to the other partial
  4. Resize the browser to induce a media query change.

Result expected: nothing shoud happen.
Result gotten: $$onMediaQueryChange is being called, resulting in an error cause there are no columns defined.

If I have a fix for this, will ask for a pull request.

NOTE that this was tested on chrome canary.
@akoenig akoenig added the bug label Mar 16, 2014
@akoenig
Copy link
Owner

akoenig commented Mar 16, 2014

Looks like that it is a "Chrome Canary exclusive bug", isn't it?

@akoenig
Copy link
Owner

akoenig commented Apr 22, 2014

Fixed in v0.4.3.

@akoenig akoenig closed this as completed Apr 22, 2014
@markni markni mentioned this issue Dec 17, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akoenig @nicoabie