-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin cordova-plugin-add-swift-support causes error in ionic cordova prepare command #76
Comments
Eu estava passando por isso também, e depois de mexer muito eu acabei indo diretamente na linha onde chama o script e manualmente adicionei O que eu fiz foi isso aqui: /* arquivo alterado: add-swift-support.js */
// eu manualmente adicionei node na chamada '.exec'. Isso foi na linha 334 para mim, na sua pode estar diferente
334 | childProcess.exec('node "' + script + '"', {}, (error, stdout, _) => {...
.... Tenho quase certeza que era para o shebang funcionar aqui, chamando o processo node, mas por algum motivo isso está acontecendo. Como não testei em outros lugares, não sei o quanto isso vai ser útil para você. Pense nisso mais como uma gambiarra que pode dar certo. |
have some news? |
I've created a pull request joseph-montanez:patch-1 to resolve this issue. If you want to swap to my repo until it is merged then: PLEASE BACKUP your cordova platform rm android
cordova plugin rm cordova-plugin-add-swift-support
cordova plugin add "github:joseph-montanez/cordova-plugin-add-swift-support#80289f8654027b4d447ada5ae55fac9dd5ae0e49"
cordova platform add android If you have an external plugin that is pulling cordova-plugin-add-swift-support then you can use overrides: "devDependencies": {}
"overrides": {
"cordova-plugin-add-swift-support": "github:joseph-montanez/cordova-plugin-add-swift-support#80289f8654027b4d447ada5ae55fac9dd5ae0e49"
}, Then you can run the same commands but, force removal as you'll get an error trying to remove the plugin thats being depended on. cordova platform rm android
cordova plugin rm -f cordova-plugin-add-swift-support
cordova plugin add "github:joseph-montanez/cordova-plugin-add-swift-support#80289f8654027b4d447ada5ae55fac9dd5ae0e49"
cordova platform add android After that you should be able to run prepare now. cordova prepare |
Thanks for making this fix. I'm having trouble installing it. I'm using cordova-plugin-zeroconf which depends on this. I tried the steps above but the version of this plugin in plugins/cordova-plugin-add-swift-support/ is still the broken one. I tried to change the link to "github:joseph-montanez/cordova-plugin-add-swift-support#patch-1", but cordova doesn't seem to like that. EDIT: I got it. I think you posted the wrong SHA. It should be db9fc7a |
Hi @akofman ! When i try prepare android with ionic command "ionic cordova prepare android " i reseive this error:
I followed the advice given in the bug report: OneSignal/OneSignal-Cordova-SDK#725 and when removing cordova-plugin-add-swift-support the prepare command worked normally. When I added it again the error occurred again.Aseguir estão minhas informações do ambiente de desenvolvimento e o log do comando "ionic cordova prepare android"
Ionic info:
Cordova Info:
Results ionic cordova prepare android -- verbose
The text was updated successfully, but these errors were encountered: